- Status Closed
- Percent Complete
- Task Type Bug Report
- Category
- Assigned To No-one
- Operating System
- Severity Low
- Priority
- Reported Version
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#2324 - setskill has insufficient system output
/setskill target all 400
will only return “> fine” which is insufficient if the wrong target was chosen;
also /setskill target “Crystal Way” 40 will only tell from which level to which it was changed but not tell the target, which is confusing as the target could be yourself, for instance, requiring to doublecheck.
Please add the name of the target to output.
Closed by peeg
11.10.2008 18:04
Reason for closing:
Additional comments about closing:
11.10.2008 18:04
Reason for closing:
Additional comments about closing:
Tested.
Please open a new report
if you want to continue the discussion
about "/setskill -1".
sounds like a nice bug to me ;)
committed to r2212
/setskill target all -1 shows an onscreen and system message to the target, although it is simply displaying the skills to the GM but is not altering anything. Please remove notification for the target (the "Your skills have been set to -1" warning to the player, not the output to the GM) for this case.
Done - committed in r2222.
kerol by the way should that "fine" message sent to the client be removed entirely? it's useless and doesn't really tell what is it XD
okay, tested it again and it seems to work. The GM is informed now apropriately when "all" is used with a certain value or with -1 to get all skills values. However there is a *very slight* strange output for a user whose skills are set (when using "all"). The output for the user looks like this (when setting to 400):
"Your 'all' level was set to 400 by a GM"
This not only sounds strange but is wrong because there is no "all" skill. I think this should be changed to "All your skills were set to 400 by a GM". That is why I let this bugreport open for now.
Playing with setskill -1 on trunk 2222. The message to the other player is gone. Should setskill -1 which reads skills be dependant on whether you can set the skills on someone else?
well right now it is the access level is only checked on target level (target != me ⇒ check the setskill on others). maybe kerol can comment also on this
@Aiken: Why should the possibility to read skills be dependant on the ability to set them? Is there a necessity for that?
I was thinking about that matter before. Maybe it would be best to have
/setskill target all -1 refactored and put into /inspect so that you would call it via
/inspect [target] skills
and the current behaviour of /inspect via
/inspect [target] inventory
But I'm not sure how much more work this would be, but I think that would be the best solution overall.
would this then depreciate the stats/skills in the desc window?
removed the fine message in r2224
Further discussion on setskill -1 on
FS#2378