- Status Closed
- Percent Complete
- Task Type Bug Report
- Category
-
Assigned To
Paul O'Reilly - Operating System
- Severity Medium
- Priority
- Reported Version
- Due in Version Undecided
-
Due Date
Undecided
-
Votes
1
- Matt Howe (10.07.2008)
- Private
FS#832 - Dequip shortcuts are buggy
Equip 2 weapons and create the following shortcut:
/dequip righthand
/dequip lefthand
Clicking the shortcut causes the righthand weapon to move to the lefthand whist the lefthand weapon moves to the inventory. This makes it necessary to click twice to fully dequip. Adding more dequip commands makes things even more complex.
Fixed, bar ‘ghost’ equipment pictures in inventory GUI. There are likely to have same cause as #1299.
Patch code can be found here: http://pastebin.ca/1033000
| ID | Project | Summary | Priority | Severity | Assigned To | Progress | |
|---|---|---|---|---|---|---|---|
| 2340 | PlaneShift | Low | Tristan Cragnolini, Roland Schulz |
Closed by peeg
07.12.2008 22:12
Reason for closing:
Additional comments about closing:
07.12.2008 22:12
Reason for closing:
Additional comments about closing:
Fixed in svn by Geckolous.
It's known that dequip shortcuts only execute one command at a time. For example if you have a shortcut to dequip 5 armour pieces, you have to click the shortcut 5 times to dequip all armour pieces successfully. This is known and reported on the old bugtracker. The only new issue I see here is that you dequip the sword in your right hand, and that it then moves to your left hand instead of moving to the inventory.
As Thom already said, this is already reported. The bug is
http://www.hydlaa.com/bugtracker/bug.php?op=show&bugid=2869&pos=5 I added info from this bug there, feel free to add more.
Closing this one as a duplicate
Re opened this task to close the report in the old tracker, and set to new, I also verified with 0.4 trunk.
assigning to geckolous
I retested this yesterday.
Possibly related, I also got the 'floating weapons' bug right after, the equipped weapons were attached at the feet instead of the hands, see
FS#506for a similar bug. I have never had floating weapons recently other than this, I suspect it was caused by running the double dequip shortcut.Patch uploaded.
Fixed bug by adding reserved status to paws slot's.
Currently, /dequip functions correctly. Inventory doll updates correct, however ghost items may be left in inventory.
This appears to have same cause as bug #1299
Likely due to timing of GUI update and message processing.
as a prospect please use ready to review not ready to test.
+ bulkSlots.SetSize( 64 ); ←- why that?
Another example:
/dequip Leather Torso Armor
/dequip Leather Arms Armor … fails because "You cannot swap with Leather Torso Armor: It won't fit in that slot"
Sorry for the late reply! Back now.
the bulkSlots.SetSize(64) isn't important to this fix. It was from an attempt to solve another GUI inventory annoyance.
Working on tracking down and fixing the ghosting bug now.
When fixing this, remember to take a look at the possibly related bug
FS#1299, which was transferred from the old bugtracker to here.the patch has expired, please repost
please repaste to http://psnopaste.byethost32.com/
Adding to this bug:
If you are holding two items of the same type and have a shortcut that issues the /dequip lefthand and /dequip righthand commands at the same time, both items are transfered to the same slot on the inventory. This means stacking the two items.
I first noticed this problem when, holding two daggers of very different quality, pressed the shortcut for dequip and got both items averaged.
Unode: that might be more related by automatic stacking of items (several other bug reports).
Ragnar: I was trying the patch I found (for revision 1677 :) ) and if it works will update it
I tested and it works. A shortcut with /dequip lefthand and /dequip righthand needed to be used twice to remove two axes before I applied the patch, and only once after.
I made a new patch, found here:
http://codereview.appspot.com/7903/show
committed to r2620 please test